search

apache / nano

Nano is now part of Apache CouchDB. Repo moved to https://GitHub.com/apache/couchdb-nano
https://github.com/apache/couchdb-nano
Other
1.13k stars 157 forks source link

Question about JSON-encoded parameters... #339

Closed mattgrande closed 8 years ago

mattgrande commented 8 years ago

Hi there, I was doing a compare to see if I would have any problems upgrading from 6.1.5 to 6.2. It mostly looks fine, but one thing caught my eye...

In nano.js, currently line 511, there's this:

var paramsToEncode = ['counts', 'drilldown', 'group_sort', 'ranges', 'sort'];

Each of those query params are JSON encoded. As far as I can tell, those don't have a specific meaning in Couch, though... so why was that added?

https://github.com/dscape/nano/blob/master/lib/nano.js#L509

jo commented 8 years ago

I guess this is was meant to be used with cloudant fulltext search: https://github.com/dscape/nano/commit/c03b5528b6b0759f7e001b722199f824163ad3a0