search

apache / netbeans-mavenutils-nbm-maven-plugin

Apache NetBeans Maven Utils parent pom
https://netbeans.apache.org/
Apache License 2.0
13 stars 27 forks source link

Request support for pre-processing "full" when using JDK >= 23 #201

Open jmborer opened 8 hours ago

jmborer commented 8 hours ago

As the pre-processing has changed since JDK 23 (https://inside.java/2024/06/18/quality-heads-up/) and is required by many NB platform functions, the NB Maven plugin shall force the compiler settings to:

<configuration>
      <proc>full</proc>
</configuration>

Or at least inform the user that it shall turn it to "full".

neilcsmith-net commented 6 hours ago

We should probably see if there's a way to provide a better warning. I don't think we should be changing the configuration, even if that's possible. @ebarboni what do you think on this one?

ebarboni commented 5 hours ago

I don't think nbm plugin can alter configuration for compiler plugin. Maybe a hint in the IDE could help as well of having a condition in archetypes to add this line according to JDK version.

neilcsmith-net commented 4 hours ago

Thanks! That's what I thought. Hint might be useful for pre-existing projects. Should move that request over to the IDE issue queue.

No need to add the archetype change according to version - should be OK to add in on all supported JDKs. There's a bunch of things that need updating in the archetypes already.