search

apache / netbeans

Apache NetBeans
https://netbeans.apache.org/
Apache License 2.0
2.62k stars 841 forks source link

Outline view node missing after update #4166

Open rkeen-siemens opened 2 years ago

rkeen-siemens commented 2 years ago

Apache NetBeans version

Apache NetBeans 13

What happened

The fix for NETBEANS-3196 introduced a regression. When replacing a child node with another in the OutlineView, the old node is removed but the new node is not added.

How to reproduce

No response

Did this work correctly in an earlier version?

Apache NetBeans 12.5

Operating System

Linux, Windows

JDK

Eclipse Adoptium 11.0.14.1

Apache NetBeans packaging

Apache NetBeans platform

Anything else

No response

Are you willing to submit a pull request?

No

Code of Conduct

Yes

mbien commented 2 years ago

@eirikbakke could you take a look at this? #1779 might have caused a regression.

eirikbakke commented 2 years ago

Hmm, I don't observe this problem in my own NetBeans Platform application, and it does call Node.setChildren all the time, and uses OutlineView as well. I've been using this patch for 3 years in both my NetBeans Platform and my build of the NetBeans IDE that I use every day.

Does the problem occur when changing from Children.LEAF to a non-LEAF, or from a non-LEAF to another non-LEAF?

Could you post an example that will help me reproduce it?

Thanks for your help!