apache / netbeans

Apache NetBeans
https://netbeans.apache.org/
Apache License 2.0
2.66k stars 853 forks source link

Rename JSF or Java Server Faces to Jakarta Faces for EE 10 #6492

Open johbor opened 1 year ago

johbor commented 1 year ago

Description

It should better for EE 10 projects to use the name Jakarta Faces for JSF or Java Server Faces. Remove JSP everywhere for Faces 4.0 see also the removals here Jakarta Faces 4.0

Use case/motivation

EE 10 projects and Jakarta Faces

Creating projects

Screenshot 2023-09-25 at 22 22 19 Screenshot 2023-09-25 at 21 50 26

Related issues

No response

Are you willing to submit a pull request?

No

mbien commented 1 year ago

want to work on this? I don't expect many using ant for Jakarta projects, so the interest in fixing this might be low.

johbor commented 1 year ago

Hello Michael,

Ik want to but I’m not in a very good condition because I have a nerve disorder in my head. The right side of my face I don’t feel anymore. So things can’t be too stressful.

But I did checkout the source of Netbeans with Git and build it with Ant. And added this build as a platform to NB19 and succeeded in setting a breakpoint on the startup and hit it.

Actually I don’t understand how to develop for NB with NB I have to learn this. E.g. a simple thing like removing the JSP choice for Faces 4.0. Or change

Any tutorial available or learning path?

By the way the code completion in the XHTML files for Faces tags is also broken.

On 26 Sep 2023, at 00:51, Michael Bien @.***> wrote:

want to work on this?

— Reply to this email directly, view it on GitHub https://github.com/apache/netbeans/issues/6492#issuecomment-1734570091, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHLQUKN3YGEB5PWEQMPGDTX4IDIRANCNFSM6AAAAAA5GVCS3M. You are receiving this because you authored the thread.

mbien commented 1 year ago

@johbor sorry to hear that, no pressure - its all good.

regarding how to build/develop NetBeans check out the readme and the second bullet point on the note: https://github.com/apache/netbeans#building-netbeans

You would build it first via command line like you already did, then open any modules you are interested in as regular projects with NetBeans and re-build/run/debug directly from there. It will start a dev build if you run a module.

asbachb commented 1 year ago

@johbor I guess the /faces/* comes from the specifications default:

When using prefix mapping, the following mapping is recommended, but not required:

<servlet-mapping>
  <servlet-name> faces-servlet-name </servlet-name>
  <url-pattern> /faces/* </url-pattern>
</servlet-mapping>

https://jakarta.ee/specifications/faces/4.0/jakarta-faces-4.0.html#a6076

I guess changing the default would require some more data than "is mostly used".

johbor commented 1 year ago

@asbachb Changing the default mapping to .xhtml also prevents the discovery of the raw .xhtml files. If not set this way but to /faces/ one can ask e.g. https://[whatever-domain]/index.xhtml and you get the raw xhtml file. But when you ask for https://[whatever-domain]/faces/index.xhtml you get the faces page as it is meant to be. When set to .xhtml the the https://[whatever-domain]/index.xhtml url delivers the faces page and not the raw xhtml

hantsy commented 10 months ago

@asbachb @johbor No need to register faces servlet for path mapping in the Java EE8/Jakarta EE 8/9/10.

Instead, I hope add Faces options(web.xml parameters) to enable the Faces features, such as Extensionless mapping in Faces 4.0, etc.