search

apache / netbeans

Apache NetBeans
https://netbeans.apache.org/
Apache License 2.0
2.69k stars 856 forks source link

Add open containing folder action. #7081

Open mbien opened 9 months ago

mbien commented 9 months ago

like open-in-system but opens the parent

this required to refactor the action hierarchy a bit to reuse existing functionality: both SystemOpenAction and SystemOpenParentAction extend AbstractSystemOpenAction

image

mbien commented 7 months ago

removed milestone

Chris2011 commented 2 months ago

As the title says "open containing folder" this is my suggestion to add it like this.

mbien commented 2 months ago

I originally had this in mind but I am still trying to find a place for another action: "Open Folder in NetBeans"

To deconflict this we would have to call it "Open Containing Folder in System" which is quite long. So I picked "Open Parent in System" which is concise and still manages to describe exactly what it does.

The other option is to use sub-menus, the problem there is that this would be 3 layers in some situations, which I would like to avoid if possible.

Chris2011 commented 2 months ago

Open Folder in NetBeans could also called "Open Folder as Project" or smth like that. It has a different context, but I'm fine with it then.

mbien commented 2 months ago

Open Folder in NetBeans (which can also open jars, who knows what else it can open) would not be the same as open project

Chris2011 commented 2 months ago

I know I already implemented this as a 3rd party plugin, but to make it clear I call it "Open Folder as Project". Because it will be shown in the project tabs. It has not all functions that a project has, but this makes it more clear IMHO. I know via CLI you can open Folder in NetBeans, which will open a folder within a new TopComponent. Is this what you mean and want to do?

Anyway, it is out of scope for this ticket and we can discuss the other stuff in another PR or via discussion. At the end, I'm fine with it, the wording in some cases in NetBeans is in my opinion not often as clear as I already told it but it is better than nothing.