Closed eirikbakke closed 1 month ago
Thanks for looking at this. The other PR looks great from a glance. This part I wonder whether should be added to https://github.com/apache/netbeans-tools instead?
This part I wonder whether should be added to https://github.com/apache/netbeans-tools instead?
Ah, that one seems like a better location; I wasn't entirely sure where to put the script. Though if there's ever a chance of the script becoming part of the official build process, then leaving it in this repo would make the git history cleaner.
Potential future changes that might be relevant to whether the script might eventually become a part of the build process:
Happy to open a PR against netbeans-tools instead if you think that's the best place for these files. Let me know what you think.
Happy to open a PR against netbeans-tools instead if you think that's the best place for these files.
It think it might be, but let's see what others think - cc/ @mbien @ebarboni @matthiasblaesing
Perhaps we revisit the idea of generating PNGs of different resolutions ... from the SVGs at build time instead of relying on the rather heavyweight NetBeans SVG loader.
Possibly. Another option might be to switch to a lighter-weight loader. Something for discussion elsewhere, perhaps mailing list, but interesting to see FlatLaf change to JSVG (as has IntelliJ) https://github.com/JFormDesigner/FlatLaf/issues/664 https://github.com/weisJ/jsvg
Happy to open a PR against netbeans-tools instead if you think that's the best place for these files.
It think it might be, but let's see what others think - cc/ @mbien @ebarboni @matthiasblaesing
If this not tied into the build process, I would keep outside the main project and indeed that was my first though when seeing this PR.
Happy to open a PR against netbeans-tools instead if you think that's the best place for these files.
It think it might be, but let's see what others think - cc/ @mbien @ebarboni @matthiasblaesing
+1 for the tools repo. If possible without the PDF for two reasons: pdfs can do too much to be in code repos IMO and secondly: it would have to be kept in sync with the illustrator file, no?
btw I could open the .ai
file with inkscape and everything seemed to show up, "New Vector" and "Old Bitpmaps" layers etc
Thanks for your comments; I have now revised the script to work from the netbeans-tools repo instead, and opened a PR there: https://github.com/apache/netbeans-tools/pull/67
This PR documents the process for drawing and installing scalable SVG versions of NetBeans icons, and commits the Illustrator File and script that was used to assemble icons in the separate PRs https://github.com/apache/netbeans/pull/7463.
Details: