search

apache / netbeans

Apache NetBeans
https://netbeans.apache.org/
Apache License 2.0
2.63k stars 840 forks source link

Have 'Reset Windows' also reset the 'Show Editor Toolbar' setting #7470

Open eirikbakke opened 2 months ago

eirikbakke commented 2 months ago

This PR proposes a small change to the "Reset Windows" action (in the Window menu), so that the "Show Editor Toolbar" setting (in the "Edit" menu) is also reset to its default true value.

mbien commented 2 months ago

this should probably run the core.windows tests at least?

eirikbakke commented 2 months ago

Sorry, I misunderstood the label system. Should the "Platform" label be used whenever any test in the "platform" needs to be run, such as core.windows? I assume there is nothing more specific?

mbien commented 2 months ago

@eirikbakke right. The tool tips on the labels describe a bit what the label toggles. core.windows is part of the platform job, and if you look on the CI checks you see that it did not run. https://github.com/apache/netbeans/blob/b332b296700219ecd1d6ee6255124f3486171af3/.github/workflows/main.yml#L1026-L1027

also: adding the https://github.com/apache/netbeans/labels/ci%3Adev-build makes manual testing easier if you want that for a PR.

eirikbakke commented 2 months ago

Thanks! Is ci:dev-build something I should add for the benefit of reviewiers, or something I should only add if I need it myself?

mbien commented 2 months ago

Thanks! Is ci:dev-build something I should add for the benefit of reviewiers, or something I should only add if I need it myself?

For both cases. You can use the dev build too of course. It will stick around for 7 days unless manually removed. Ideally the PR owner did already some testing before submitting a PR though.

but it does make reviews (edit: which require manual testing) much easier with a bit of scripting

eirikbakke commented 2 months ago

OK, thank you! I'll add ci:dev-build in cases where I think it might be useful for reviewers. For my own purposes I have a local build running.

eirikbakke commented 2 months ago

One more question... If I add new labels to an existing PR, how do I cause the new tests to run? Does "Restart all jobs" do it, or am I supposed to use the "lock and unlock" trick that is mentioned on https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide ?

mbien commented 2 months ago

@eirikbakke pushing something to the PR will trigger a fresh workflow run or using the lock/unlock trick will do the same like you just did. Restarting an existing workflow run via github will not pick up new labels unfortunately.