Add class-file format to the file properties sheet

apache / netbeans

Apache NetBeans

https://netbeans.apache.org/

Apache License 2.0

2.64k stars 849 forks source link

Add class-file format to the file properties sheet #7527

Closed mbien closed 3 months ago

mbien commented 3 months ago

will now display the class-file version and the preview flag in the file properties table
little cleanup in the touched file

(last entry)

mbien commented 3 months ago

noticed a little issue: the property will also show up on .java files and display "unknown". Going to take a look if this can be improved.

converting to draft.

matthiasblaesing commented 3 months ago

Ok, a bit surprising, that .class files are handled by JavaNode, but the fix looks straight forward, so my positive review still stands.

mbien commented 3 months ago

awesome -> merging

I have also put two more items related to this on my todo list:

something similar for jars which would print some manifest info, e.g if its a multi release jar
JDK picker for "single-file-java-programs"

mbien commented 3 months ago

damn. the JDK bump causes the last two remaining jdk8 locked tests to fail. I take a quick look and might turn them off since last time I tried I gave up https://github.com/apache/netbeans/pull/5166 on it.

mbien commented 3 months ago

-> https://github.com/apache/netbeans/pull/7534