search

apache / netbeans

Apache NetBeans
https://netbeans.apache.org/
Apache License 2.0
2.59k stars 834 forks source link

PHP Blade and Laravel support for netbeans #7531

Open haidubogdan opened 1 week ago

haidubogdan commented 1 week ago

Description

Blade and Laravel support for netbeans

Laravel framework with blade templating are very popular, so it makes sense to include them in the Netbeans IDE - PHP. I worked on a personal blade plugin for netbeans on https://github.com/haidubogdan/netbeans-php-blade-plugin. By adding this plugin in the netbeans repository the following features will be added :

There is also a work in progress plugin for laravel framework https://github.com/haidubogdan/netbeans-php-laravel-framework It will include utility tools like :

Use case/motivation

The main goal is to help the development process of PHP projects done in laravel. I will assume the main development process.

Related issues

No response

Are you willing to submit a pull request?

Yes

matthiasblaesing commented 4 days ago

Not sure what is the intention of this issue. There is no need for an issue to get things into NetBeans. The normal process is to prepare a PR for the feature you want to implement, get it reviewed (might involve multiple cycles) and then get a committer to actually merge it to master.

It helps (from my perspective) if the PR is focused and changes things incrementally. I.e. finding someone to review a PR that changes the whole way PHP is handled in the IDE will be impossible, finding someone, who reviews a PR, that fixes a specific issue and validates that with tests is much more likely.

From my perspective the two primary contacts for PHP development in the IDE are @junichi11 and @tmysik and it would be good if they could chime in.

tmysik commented 4 days ago

Totally agree with @matthiasblaesing, creating a PR (or perhaps better, more smaller PRs, if possible?) would be great. Definitely ask for review from @junichi11, I can try to help too.

Thank you.

haidubogdan commented 4 days ago

Ok, I will keep this issue opened to have a backtracking of this proposed evolution. So a simple Fork and PR should be enough then ?

matthiasblaesing commented 4 days ago

@haidubogdan the general answer is:

  1. You create a personal fork of the NetBeans repository
  2. You create a new branch from current master to work on your feature
  3. You create a PR from that branch

If your changes can be integrated independently, steps 2+3 can be done multiple times in parallel. If they build on top of each other, you can create new branches based on the PR branch for next step. However you should be prepared to rebase that work onto the finally reviewed PR branch. While a PR is in review there is a quite big chance, that changes will have to be done as part of that.