search

apache / netbeans

Apache NetBeans
https://netbeans.apache.org/
Apache License 2.0
2.63k stars 840 forks source link

Move Gradle module to Java 17 and NbProjectInfoAction to Java 8 #7543

Closed lkishalmi closed 1 month ago

lkishalmi commented 2 months ago

This one could be a solution: #7365

errael commented 1 month ago

... at finding those issues so I have heard, maybe he could check ;)

Seems more like they find me. It's not nearly as much fun/motivating if the product isn't about to ship.

I'm happy to give it a try, though I haven't used NB since around the time #7365 was opened.

Hopefully I'll see the commit go by, and then a few days later figure out (remember) how to download a daily. Or someone points me to a zip release with this PR.

sdedic commented 1 month ago

@errael, @lkishalmi I've tried to open https://github.com/errael/astrology-castro/ to check the behaviour but the project loaded fine (after I removed the part with sonatype credentials).

How should I reach the failure ?

neilcsmith-net commented 1 month ago

@sdedic if you're trying to replicate #7365 then it was fixed in 22-rc4, so you'd have to go back before then. If it loads fine with this PR (as hoped) then that's a good sign!

sdedic commented 1 month ago

maybe I misunderstood @lkishalmi 's first comment then :-/

neilcsmith-net commented 1 month ago

@sdedic this PR makes the same change to Java 17 as included in #7257 while trying to avoid #7365 The original update to Java 17 was reverted. The description could probably do with more info.

The key thing is to ensure that NbProjectInfoAction is separated from the module and built with Java 8 as that class has to be deserializable into the running Gradle build and JDK. Given how that deserialization works, it's probably a good idea to keep separate from the module JAR too.

mbien commented 1 month ago

@errael here a dev build https://github.com/apache/netbeans/actions/runs/9891644164/artifacts/1690947578

mbien commented 1 month ago

maybe I misunderstood lkishalmi 's first comment then :-/

@sdedic The problem is not in NB 22 since we reverted https://github.com/apache/netbeans/pull/7367 a subset of the original PR during stabilization phase which is the normal procedure, esp later in the phase. This is a reworked patch for NB 23 which hopefully does not cause a variant of https://github.com/apache/netbeans/issues/7365 again.

errael commented 1 month ago

I've tried to open ... but the project loaded fine How should I reach the failure ?

That's it; #7365 are open failures. I just used the provided dev-build. It does not have the project opening problems. I tried setting a breakpoint; running the project. All is well.

It's looking like I'll have some work to do on these projects using NB over the next few weeks. I'll try to put it off until 23-RC1 is ready.

@mbien BTW, in case I want to use that "latest", I looked at the download page and github actions page; it's not obvious how to pick up the latest dev build.

mbien commented 1 month ago

@mbien BTW, in case I want to use that "latest", I looked at the download page and github actions page; it's not obvious how to pick up the latest dev build.

dev-builds (master branch, like "nightly builds") are linked from the readme: https://github.com/apache/netbeans?tab=readme-ov-file#download

the link I posted was a build this PR produced, also a dev build but built from the PR branch (so it includes the changes, the nightly build does not).

errael commented 1 month ago

dev-builds (master branch, like "nightly builds") are linked from the readme

Doh! Old school; thanks.