search

apache / netbeans

Apache NetBeans
https://netbeans.apache.org/
Apache License 2.0
2.64k stars 849 forks source link

Reduce redundant cast warnings #7552

Closed BradWalker closed 3 months ago

BradWalker commented 3 months ago

Reduce redundant cast warnings. These happen as a side result of code cleanup..

Reduce warnings that look like this:

[repeat] /home/bwalker/src/netbeans/enterprise/tomcat5/src/org/netbeans/modules/tomcat5/util/LogManager.java:271: warning: [cast] redundant cast to LogViewer [repeat] contextLog = (LogViewer)contextLogViewers.get(moduleID); [repeat] ^Cleanup redundant casts. These are a side effect of work done doing code cleanup.

mbien commented 3 months ago

when you do project wide refactorings you have to let all tests run

BradWalker commented 3 months ago

I thought I had done that.. Where did should I have been looking? BTW, my apologies. I'm a little rusty this days. 8-)

mbien commented 3 months ago

https://github.com/apache/netbeans/labels/ci%3Aall-tests enables all tests which is useful for project wide cleanup PRs or changes which could affect multiple areas of the IDE.

the CI section of https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide has more details and screenshots