apache / netbeans

Apache NetBeans
https://netbeans.apache.org/
Apache License 2.0
2.64k stars 849 forks source link

Update manifest of core.output2 to separate the OpenIDE-Module-Provides values with comma #7584

Closed YannLeCorse closed 3 months ago

YannLeCorse commented 3 months ago

In a Netbeans application based on Maven, the nbm-maven-plugin is failing with the following message while both modules are explicitly part of the application.

[ERROR] Some tokens required by included modules are not provided by included modules. The application will fail starting up. The missing tokens are:
[ERROR]    org.openide.windows.IOProvider          ref: [org.netbeans.modules.css.visual]

Looking at the ExamineManifest source code the nbm-maven-plugin is expecting to find comma separated values.

Looking at the other Manifest on Netbeans source code, it seems that other are comma separated already

Thus core.output2 seems to have a typo addressed by this pull request.

YannLeCorse commented 3 months ago

@YannLeCorse thanks for fixing this!

My one character contribution pleasure.