search

apache / netbeans

Apache NetBeans
https://netbeans.apache.org/
Apache License 2.0
2.65k stars 850 forks source link

Fix Command Prefixing Issue in Source Action #7621

Closed Achal1607 closed 3 months ago

Achal1607 commented 3 months ago

In PR #6990, some refactoring was done on the source actions to incorporate VSCode changes. During this process, the command arguments for the required source action were hardcoded with the nbls prefix without checking the NBCode extended capabilities prefix flag. This introduced a regression for extensions other than the Apache Java extension that use the NetBeans LSP, causing the source action menu to stop working.

This fix ensures that the source action commands are properly prefixed, respecting the NBCode extended capabilities prefix flag, and restores functionality for all relevant extensions.

For more info: https://github.com/oracle/javavscode/issues/214 and https://github.com/oracle/javavscode/issues/215

mbien commented 3 months ago

is this fix for NB 23 or 24?

Achal1607 commented 3 months ago

If it goes in NB-23 then it would be great because oracle java extension has broken source action functionality currently.

mbien commented 3 months ago

If it goes in NB-23 then it would be great because oracle java extension has broken source action functionality currently.

@Achal1607 Since NB is post feature freeze, this would have to be rebased onto the delivery branch and then also target delivery.

https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery

(this also should not be merged by committers, only reviewed. The release manager @ebarboni would merge)