Fix Maven annotation processor path list query.

mbien commented 2 months ago

Maven Lists can often have arbitrary item names. NetBeans did only look for elements named <path>, this patch will update the logic to iterate over all elements.

fixes #7658

matthiasblaesing commented 2 months ago

~~-1 I have a local branch ready, there is no need to rush this, this is no regression~~

matthiasblaesing commented 2 months ago

To give some perspective on the why for my initial "-1":

I investigated #7611
Discovered, that "the reproducer" was a different bug, than the reported one
Proposed a solution for the original problem of #7611 (which is not a bug, but a broken build setup)
Prototyped a fix for the secondary bug of #7611

And then I made the error to create issue #7658, without referencing #7611 and assigning it to me.

Then before I could push my fix, you intervened. Frankly NetBeans currently is not fun for me and that added just nicely. I assume, there was not intent here, but the timing was just bad.

mbien commented 2 months ago

Then before I could push my fix, you intervened. Frankly NetBeans currently is not fun for me and that added just nicely. I assume, there was not intent here, but the timing was just bad.

Its all good. I just don't want that you see this as intervention, since all I did was to open a PR. My mistake was that I did not realize that you worked on that issue, the first time I realized this is when I read your comment at https://github.com/apache/netbeans/issues/7658#issuecomment-2282881400, if you look at the timestamps and take into account that I don't reload pages all the time, both happened within the same minute.

closing in favor of https://github.com/apache/netbeans/pull/7662

apache / netbeans

Fix Maven annotation processor path list query. #7661