tools/Wasm.mk problems - Githubissues

apache / nuttx-apps

Apache NuttX Apps is a collection of tools, shells, network utilities, libraries, interpreters and can be used with the NuttX RTOS

https://nuttx.apache.org/

Apache License 2.0

273 stars 521 forks source link

tools/Wasm.mk problems #2046

Open yamt opened 1 year ago

yamt commented 1 year ago

the idea to build wasm modules using nuttx headers is broken
it produces very WAMR specific modules (it seems targeting WAMR's LIBC_BUILTIN). if we want to build wasm modules, it's better to target wasm32-wasi.
WCC detection is broken. for example, github ubuntu-22.04 runners have /bin/clang, which confuses the detection.
CONFIG_INTERPRETERS_WASM vs CONFIG_INTERPRETERS_WASM3 typo

my proposal: remove it

an alternative:

target it to wasm32-wasi
have an explicit config to enable it (disable it by default)

anchao commented 1 year ago

@yamt We are not using the implementation of wasi/wasi-libc. We have a python script to parse nuttx csv files(syscall/libc/libm) to automatically generate nuttx syscall/libc/libm glue codes. Currently, this feature works as expected without boundary checking in wamr, but it still needs some work if enable boundary check.

yamt commented 1 year ago

@yamt We are not using the implementation of wasi/wasi-libc. We have a python script to parse nuttx csv files(syscall/libc/libm) to automatically generate nuttx syscall/libc/libm glue codes. Currently, this feature works as expected without boundary checking in wamr, but it still needs some work if enable boundary check.

where can i find the python script?

anchao commented 1 year ago

where can i find the python script?

I will upload a draft ASAP

yamt commented 1 year ago

why do you prefer the "no sandbox" approach? doesn't it spoil many of benefits of wasm?

no1wudi commented 1 year ago

@yamt Please refer to this PR https://github.com/apache/nuttx-apps/pull/2058