search

apache / nuttx-apps

Apache NuttX Apps is a collection of tools, shells, network utilities, libraries, interpreters and can be used with the NuttX RTOS
https://nuttx.apache.org/
Apache License 2.0
268 stars 504 forks source link

fix variable set but not used #2302

Closed Gary-Hobson closed 6 months ago

Gary-Hobson commented 6 months ago

Summary

These variables will trigger variable 'ret' set but not used warnings due to different configurations.

For using variables only in assert, added UNUSED to declare Warnings in external repositories are ignored in the makefile

Impact

Let's ignore the following format check, which seems to have nothing to do with this change

apps/modbus/nuttx/porttimer.c:51:9: error: Mixed case identifier found
  return xMBPortSerialSetTimeout(ulTimeOut);

Testing

acassis commented 6 months ago

Please verify the issues with sim/zipfs

xiaoxiang781216 commented 6 months ago

I think it doesn't need with the new approach. Let's close it now.