testing/nand_sim: Adds a virtual NAND Flash device

apache / nuttx-apps

Apache NuttX Apps is a collection of tools, shells, network utilities, libraries, interpreters and can be used with the NuttX RTOS

https://nuttx.apache.org/

Apache License 2.0

268 stars 504 forks source link

Closed resyfer closed 5 months ago

resyfer commented 5 months ago

Adds NAND Flash device in simulator Fixes echo in terminal for Vi

Adds a NAND Flash virtual device for the simulator.
Removes echo of commands in vi (especially during movement), and double echo of characters in command line in vi due to the same reason.

Basic file system operations after mounting using littlefs.
checkpatch.sh (An error that nxstyle gives, which looks to be a genuine error, is /nuttxspace/apps/testing/nand_sim/nand_sim_main.c:103:44: error: Multiple data definitions which might be in this issue).

acassis commented 5 months ago

@xiaoxiang781216 @resyfer why the CI is failing? Should Saurav rebase it to force the CI to pass?

resyfer commented 5 months ago

@acassis Hi! Sorry for the late reply. I've done a force push.

What I don't understand is this line from the error (and subsequent lines similar to it):

/github/workspace/sources/apps/testing/nand_sim/Kconfig:34: 'endif' in different file than 'if'

I have them:

6  | config TESTING_NAND_SIM
...
12 | if TESTING_NAND_SIM
...
34 | endif

I had tried force pushing earlier after rebasing, but it still showed this CI error.

resyfer commented 5 months ago

@acassis @xiaoxiang781216 Hi, can you please approve this PR for CI testing? Thank you!

acassis commented 5 months ago

Hi @resyfer sorry I missed your message. I don't look nuttx-apps so often as I do for nuttx kernel. I hope now it works fine

resyfer commented 5 months ago

Hi @acassis no worries! Thanks for the approval. It also looks like the CI tests have completed finally.

resyfer commented 5 months ago

Thank you for the review!