Closed resyfer closed 5 months ago
@xiaoxiang781216 @resyfer why the CI is failing? Should Saurav rebase it to force the CI to pass?
@acassis Hi! Sorry for the late reply. I've done a force push.
What I don't understand is this line from the error (and subsequent lines similar to it):
/github/workspace/sources/apps/testing/nand_sim/Kconfig:34: 'endif' in different file than 'if'
I have them:
6 | config TESTING_NAND_SIM
...
12 | if TESTING_NAND_SIM
...
34 | endif
I had tried force pushing earlier after rebasing, but it still showed this CI error.
@acassis @xiaoxiang781216 Hi, can you please approve this PR for CI testing? Thank you!
Hi @resyfer sorry I missed your message. I don't look nuttx-apps so often as I do for nuttx kernel. I hope now it works fine
Hi @acassis no worries! Thanks for the approval. It also looks like the CI tests have completed finally.
Thank you for the review!
Adds NAND Flash device in simulator Fixes echo in terminal for Vi
Summary
vi
(especially during movement), and double echo of characters in command line invi
due to the same reason.Impact
vi
more usableTesting
checkpatch.sh
(An error that nxstyle gives, which looks to be a genuine error, is/nuttxspace/apps/testing/nand_sim/nand_sim_main.c:103:44: error: Multiple data definitions
which might be in this issue).