Closed slorquet closed 5 months ago
Hi, can you apply this as soon as checks complete? I have more changes to send, I would like to avoid parallel pull requests, thanks.
Hi, can you apply this as soon as checks complete? I have more changes to send, I would like to avoid parallel pull requests, thanks.
It's better to create pull request parallel If you change is independent each other. All committers come from the different time zone and have daily job to be done in the working time.
yes of course, I do that always. but having to manage several pending changes in parallel breaks my brain a little.
Summary
dhcpc can run in async mode with a background thread. this can be cancelled (when the link goes down)
but when the link goes up again the variable dhcpc_state->cancel is not reinitialized, so the async mode works only once
Impact
dhcpc async thread can be started multiple times
Testing
verified to work experimentally on a stm32f4 custom board