apps/nshlib: Never disable HELP and ?

apache / nuttx-apps

Apache NuttX Apps is a collection of tools, shells, network utilities, libraries, interpreters and can be used with the NuttX RTOS

https://nuttx.apache.org/

Apache License 2.0

264 stars 490 forks source link

apps/nshlib: Never disable HELP and ? #2344

Closed acassis closed 3 months ago

acassis commented 3 months ago

Summary

Never disable HELP and ?

Impact

Users will be able to see available commands in NSH

Testing

stm32f103-minimum

Please ignore the CI failing, it needs https://github.com/apache/nuttx/pull/12038 because default board config changed (chichen-egg dilemma).

acassis commented 3 months ago

@xiaoxiang781216 could you please merge?

xiaoxiang781216 commented 3 months ago

@xiaoxiang781216 could you please merge?

but defconfig from stm32f103-minimum/nsh need update too.

xiaoxiang781216 commented 3 months ago

@acassis please rebase your patch to pass ci.

acassis commented 3 months ago

Done

acassis commented 3 months ago

The commit message and PR description are a little confusing. Instead of "Never disable HELP and ?" I recommend "Enable HELP and ? by default."

It is same as 0 and "Oh", I used the name of CONFIG_NSH_DISABLE_HELP as reference. It is not disabling HELP, but internally it could be disabled if others requirements are not met