search

apache / nuttx-apps

Apache NuttX Apps is a collection of tools, shells, network utilities, libraries, interpreters and can be used with the NuttX RTOS
https://nuttx.apache.org/
Apache License 2.0
263 stars 488 forks source link

toywasm: ignore compile warnings #2396

Closed Gary-Hobson closed 1 month ago

Gary-Hobson commented 1 month ago

Summary

Will cause compilation warning if NDEBUG is defined We can't modify the code of the external library, so let's ignore it

Impact

Testing

yamt commented 1 month ago

i guess you can mirror this https://github.com/yamt/toywasm/blob/master/cmake/ToywasmConfig.cmake#L298-L302 and leave a reference in a comment so that it can be updated when/if it was changed in the upstream.

xiaoxiang781216 commented 1 month ago

let's ignore the unrelated sim ltp test failure, @ttnie is working on it.

yamt commented 1 month ago

let's ignore the unrelated sim ltp test failure, @ttnie is working on it.

the ci still built relevant configs (sim:toywasm and esp32s3-devkit:toywasm) successfully. let's merge this.