search

apache / nuttx-apps

Apache NuttX Apps is a collection of tools, shells, network utilities, libraries, interpreters and can be used with the NuttX RTOS
https://nuttx.apache.org/
Apache License 2.0
275 stars 521 forks source link

Revert "testing/ostest: Fix config name" #2397

Closed Donny9 closed 4 months ago

Donny9 commented 4 months ago

Summary

this patch https://github.com/apache/nuttx-apps/pull/2394 enable vfork test, but vfork test is failed in sim:citest so, let's recover this patch after fix crash.

Impact

fix ci break

Testing

local test

Donny9 commented 4 months ago

@xiaoxiang781216 @ttnie @SPRESENSE

SPRESENSE commented 4 months ago

@Donny9 CONFIG_ARCH_HAVE_VFORK is not defined anywhere. I think it would be better to remove the select for CONFIG_ARCH_HAVE_FORK from CONFIG_ARCH_SIM to avoid sim:citest failure so that other architectures are not affected.

xiaoxiang781216 commented 4 months ago

@Donny9 CONFIG_ARCH_HAVE_VFORK is not defined anywhere. I think it would be better to remove the select for CONFIG_ARCH_HAVE_FORK from CONFIG_ARCH_SIM to avoid sim:citest failure so that other architectures are not affected.

good suggestion. @Donny9 let's disable fork test on sim util the problem gets fixed.

Donny9 commented 4 months ago

@SPRESENSE @xiaoxiang781216 okay，new patch:https://github.com/apache/nuttx/pull/12375 on nuttx/