apache / nuttx-website

Apache NuttX Website
https://nuttx.apache.org/
Apache License 2.0
16 stars 23 forks source link

ci: Properly capture username it git config #94

Closed btashton closed 1 year ago

btashton commented 1 year ago

Summary

Git username that contained certain symbols such as Tomasz 'CeDeROM' CEDRO does not get captured properly when setting the git config in the workflow

~/nuttx-wrk/nuttx-website on  master via 💎 v3.0.2 
❯  username="`git log -1 --pretty=format:'%an'`"
email="`git log -1 --pretty=format:'%ae'`"
❯ echo $username
Tomasz 'CeDeROM' CEDRO
❯ echo $email
tomek@cedro.info
❯ git config user.name $username
usage: git config [<options>]

Config file location
    --global              use global config file
    --system              use system config file
....

With this change

❯ git config user.name "$username"
❯ git config user.name
Tomasz 'CeDeROM' CEDRO
btashton commented 1 year ago

@acassis / @cederom this will resolve the CI issue that was preventing the recent changes from being published.

cederom commented 1 year ago

Thank You @btashton :-)