apache / nuttx

Apache NuttX is a mature, real-time embedded operating system (RTOS)
https://nuttx.apache.org/
Apache License 2.0
2.6k stars 1.11k forks source link

Changing configuration via 'make menuconfig' does not work sometimes on MACOS #9670

Closed pkarashchenko closed 1 year ago

pkarashchenko commented 1 year ago

Steps to reproduce:

  1. ./tools/configure.sh sim:citest
  2. make menuconfig -> select CONFIG_LIBCXXABI=y -> Save & Exit
  3. make -j8 ->
    Create version.h
    sed: 1: "/CONFIG_BASE_DEFCONFIG/ ...": bad flag in substitute command: '}'
    make: *** [include/nuttx/config.h] Error 1
    make: *** Waiting for unfinished jobs....

Another example:

  1. ./tools/configure.sh sim:ostest
  2. make menuconfig -> select CONFIG_STDIO_DISABLE_BUFFERING=y -> Save & Exit
  3. make -j8 ->
    Create version.h
    sed: 1: "/CONFIG_BASE_DEFCONFIG/ ...": bad flag in substitute command: '}'
    make: *** [include/nuttx/config.h] Error 1
    make: *** Waiting for unfinished jobs....
pkarashchenko commented 1 year ago

Seems to be regression after https://github.com/apache/nuttx/commit/bc4266fa485

pkarashchenko commented 1 year ago

@lucasssvaz could you please take a look?

acassis commented 1 year ago

@lucasssvaz please take a look!

lucasssvaz commented 1 year ago

Just came back from vacation, sorry for all the trouble. I messed up the differences between Linux and OSX sed's. You can't omit the semicolon on OSX, that's why the error occurs. @pkarashchenko I currently don't have an OSX machine to test. Could you please check if #9754 now works as expected ?

pkarashchenko commented 1 year ago

Ok. Let me check

pkarashchenko commented 1 year ago

@lucasssvaz seems to be working fine.

lucasssvaz commented 1 year ago

Thank you! I'll open the PR.