search

apache / opendal

Apache OpenDAL: One Layer, All Storage.
https://opendal.apache.org
Apache License 2.0
3.44k stars 481 forks source link

Temporarily disable `services-ftp` from binding #3650

Closed suyanhanx closed 11 months ago

suyanhanx commented 11 months ago

But due to https://github.com/async-rs/async-tls/issues/55, services-ftp is still blocked on old rustls. I think we can remove it from bindings (for java/nodejs/python) until it has been resolved.

Originally posted by @Xuanwo in https://github.com/apache/incubator-opendal/issues/3632#issuecomment-1822252755

Tasks

Disable the services/ftp in released bindings.

Xuanwo commented 11 months ago

It's a breaking change, we should add in every binding's upgrade docs.

ayushkanyal commented 11 months ago

Hey @suyanhanx , I am a beginner to open-source and would love to contribute to this project. Please let me know if you need a hand.

Xuanwo commented 11 months ago

Hey @suyanhanx , I am a beginner to open-source and would love to contribute to this project. Please let me know if you need a hand.

Thank you so much! Actually, I could really use your help with this issue.

To disable services-ftp, we just need to remove services-ftp from python/java/nodejs bindings and update the upgrade.md docs.

ZutJoe commented 11 months ago

can i try this or waiting for @ayushkanyal ?

Does updating the contents of upgrade.md just need to copy the content

Xuanwo commented 11 months ago

Does updating the contents of upgrade.md just need to copy the content

Yep!