Open Xuanwo opened 10 months ago
If I understand correctly, there are a few typos in the RFC.
L37 in RFC text.
+ pub async fn delete_with(&self, path: &str) -> FutureDelete;
delete_with
already return Future, async
keyword is not necessary.
L40 in RFC text.
+ pub async fn deleter_with(&self) -> FutureDeleter;
same as above.
L99 in RFC text.
let deleter = op.deleter()
// Allow up to 8 concurrent delete tasks, default to 1.
.concurrent(8)
// Configure the buffer size to 1000, default value provided by services.
.buffer(1000)
.await?;
// Add a single file to the deleter.
deleter.delete(path).await?;
// Add a stream of files to the deleter.
deleter.delete_all(&mut lister).await?;
// Close deleter, make sure all input files are deleted.
deleter.close().await?;
op.deleter()
should be op.deleter_with()
Thanks a lot! Would you like to submit a PR to fix them all?
Tasks
oio::Delete
delete
to returnoio::Delete
inAccessor
batch
APIdeleter
toOperator
remove
,remove_via
APIsrecursive
inOpDelete
remove_all
APIs