search

apache / opendal

Apache OpenDAL: One Layer, All Storage.
https://opendal.apache.org
Apache License 2.0
3.44k stars 481 forks source link

new feature: Support for client secret auth against azdls #4943

Open twuebi opened 3 months ago

twuebi commented 3 months ago

Feature Description

It seems that azdls-service currently only supports sas / sharedkey / imds auth but it doesn't support the client_secret auth method which would work with app registration / entra id.

Problem and Solution

This feature enables using azdls with microsoft app registration. It should either take care of refreshing / logging in again, e.g. via some background task / checking expiry before issuing a request or expose the means to refresh tokens to the user, e.g. via some Arc<RwLock<Token>> which is exposed on the api.

Additional Context

No response

Are you willing to contribute to the development of this feature?

twuebi commented 3 months ago

I've started by opening a PR against reqsign which adds support for client-secret authentication https://github.com/Xuanwo/reqsign/pull/457

twuebi commented 1 month ago

Hi @Xuanwo, do you think we could create a reqsign release with client-secret authentication support? We could then continue with the work here in opendal.

Xuanwo commented 1 week ago

Hi, @twuebi, sorry for the long wait. @TennyZhuang helped cherry-pick https://github.com/Xuanwo/reqsign/pull/457 to v0.16.x branch, and I will release new version based on this. You can continue your work now.