apache / opendal

Apache OpenDAL: One Layer, All Storage.

https://opendal.apache.org

Apache License 2.0

3.45k stars 482 forks source link

refactor(layers/prometheus-client): provide builder APIs #5073

Closed koushiro closed 2 months ago

koushiro commented 2 months ago

Which issue does this PR close?

Related issue: https://github.com/apache/opendal/pull/5069#discussion_r1736066873 Related PR: https://github.com/apache/opendal/pull/5072

Rationale for this change

Provide similar APIs for PrometheusLayer and PrometheusClientLayer

What changes are included in this PR?

support configurable params like PrometheusLayer
add PrometheusClientLayer::builder
add PrometheusClientLayerBuilder
fix metrics name
remove OperationErrorsTotalLabels
add more examples in doc

Are there any user-facing changes?

API breaking change

koushiro commented 2 months ago

@Xuanwo maybe you can also take a look at this PR?

Xuanwo commented 2 months ago

@Xuanwo maybe you can also take a look at this PR?

This PR appears to include many changes from https://github.com/apache/opendal/pull/5072. Perhaps we should merge https://github.com/apache/opendal/pull/5072 first?

koushiro commented 2 months ago

@Xuanwo maybe you can also take a look at this PR?

This PR appears to include many changes from #5072. Perhaps we should merge #5072 first?

Yeah, I just want to give you more information about why I wrote this to provide similar APIs.