apache / opendal

Apache OpenDAL: access data freely.
https://opendal.apache.org
Apache License 2.0
3.34k stars 471 forks source link

Tracking Issues with Conditional Requests #5218

Open Xuanwo opened 1 week ago

Xuanwo commented 1 week ago

OpenDAL supports conditional requests at the API level, although not all supported services have implemented them. This issue is used to track their implementation.

Steps

Implement if_none_match for write like this https://github.com/apache/opendal/pull/5129

https://github.com/apache/opendal/blob/b92cfc41ba0a93acc5ff519b48af262bd91585d9/core/src/services/s3/core.rs#L335-L337

Services

Xuanwo commented 1 week ago

Hello @ForestLH, thank you for adding support for S3's conditional write. However, the previous PR only covered simple writes. Would you be interested in extending this to multipart uploads as well?

ForestLH commented 1 week ago

Hello @ForestLH, thank you for adding support for S3's conditional write. However, the previous PR only covered simple writes. Would you be interested in extending this to multipart uploads as well?

Sure, my pleasure. But I don't have an account for one of these cloud services(like cos, azblob, azdls...), and I want to know some easier methods than sign up for them to test my code. Thanks.

Xuanwo commented 1 week ago

For Azblob, you can use https://github.com/Azure/Azurite. We have a fixture available at: https://github.com/apache/opendal/blob/main/fixtures/azblob/docker-compose-azurite.yml.

For other services, we have only configured continuous integration so far. You can submit PR and I can help trigger the CI for you.

ForestLH commented 1 week ago

For Azblob, you can use https://github.com/Azure/Azurite. We have a fixture available at: https://github.com/apache/opendal/blob/main/fixtures/azblob/docker-compose-azurite.yml.

For other services, we have only configured continuous integration so far. You can submit PR and I can help trigger the CI for you.

Thanks for your help. plz assign me, I will try it.

Xuanwo commented 1 week ago

Thank you @ForestLH!