apache / opendal

Apache OpenDAL: One Layer, All Storage.
https://opendal.apache.org
Apache License 2.0
3.46k stars 486 forks source link

bug: bindings/c Bump CMake version to allow successful builds of the binary #5307

Closed palash25 closed 1 week ago

palash25 commented 1 week ago

Describe the bug

under bindings/c the CMakeLists.txt file mentions the following CMake policy cmake_policy(SET CMP0135 NEW) but the minimum version of CMake is set to 3.22 whereas the policy used was introduced in version 3.24

Steps to Reproduce

Go to bindings/c and follow the instructions in CONTRIBUTING.md. Running cmake will produce this error

 cmake ..
CMake Error at CMakeLists.txt:19 (cmake_policy):
  Policy "CMP0135" is not known to this version of CMake.

Expected Behavior

The build should succeed without any errors given the minimum version of CMake installed is correct

Additional Context

https://cmake.org/cmake/help/latest/policy/CMP0135.html

Are you willing to submit a PR to fix this bug?