apache / opendal

Apache OpenDAL: One Layer, All Storage.
https://opendal.apache.org
Apache License 2.0
3.46k stars 486 forks source link

refactor(core)!: Remove not used cap write_multi_align_size #5322

Closed Xuanwo closed 1 week ago

Xuanwo commented 1 week ago

Which issue does this PR close?

None

Rationale for this change

write_multi_align_size is designed solely for gcs, but it's now never been used.

What changes are included in this PR?

Remove write_multi_align_size from capability.

Are there any user-facing changes?

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #5322 will degrade performances by 18.88%

Comparing remove-range-writer (d179ca9) with main (4dc0f15)

Summary

❌ 8 regressions ✅ 65 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main remove-range-writer Change
buffer 256 KiB * 32 chunk 154.4 ns 183.6 ns -15.89%
buffer 256 KiB * 4 chunk 125.3 ns 154.4 ns -18.88%
buffer 4.00 MiB * 32 chunk 125.3 ns 154.4 ns -18.88%
buffer 4.00 MiB * 4 chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 1000k truncate 245.8 ns 275 ns -10.61%
256 KiB * 100k truncate 245.8 ns 275 ns -10.61%
256 KiB * 10k truncate 245.8 ns 275 ns -10.61%
256 KiB * 1k truncate 245.8 ns 275 ns -10.61%
Xuanwo commented 1 week ago

Thank you @PsiACE for the review!