Closed Xuanwo closed 1 week ago
Comparing remove-range-writer
(dbf95bb) with main
(104727c)
⚡ 1
improvements
❌ 8
regressions
✅ 64
untouched benchmarks
:warning: Please fix the performance issues or acknowledge them on CodSpeed.
Benchmark | main |
remove-range-writer |
Change | |
---|---|---|---|---|
❌ | 256 KiB * 1000k chunk |
125.3 ns | 154.4 ns | -18.88% |
❌ | 256 KiB * 1000k truncate |
216.7 ns | 245.8 ns | -11.86% |
❌ | 256 KiB * 100k chunk |
125.3 ns | 154.4 ns | -18.88% |
❌ | 256 KiB * 100k truncate |
216.7 ns | 245.8 ns | -11.86% |
❌ | 256 KiB * 10k chunk |
154.4 ns | 183.6 ns | -15.89% |
❌ | 256 KiB * 10k truncate |
216.7 ns | 245.8 ns | -11.86% |
❌ | 256 KiB * 1k chunk |
125.3 ns | 154.4 ns | -18.88% |
❌ | 256 KiB * 1k truncate |
216.7 ns | 245.8 ns | -11.86% |
⚡ | concurrent 8 |
365.4 µs | 327.3 µs | +11.62% |
Thank you @koushiro for the review!
Which issue does this PR close?
None
Rationale for this change
Dead Code
What changes are included in this PR?
This PR will remove RangeWriter which never been used
Are there any user-facing changes?