search

apache / openmeetings

Mirror of Apache Openmeetings
Other
639 stars 260 forks source link

OPENMEETINGS-2678 Update and ignore if Notificaiton API is not available #159

Closed sebawagner closed 3 years ago

sebawagner commented 3 years ago

Disables the JS error.

solomax commented 3 years ago

@sebawagner I'll update some dependencies in master Could you please cherry-pick these changes? :)))

solomax commented 3 years ago

One more NOTE: could you please change typeof Notification to be typeof(Notification) ? (for consistency :)))

sebawagner commented 3 years ago

@sebawagner I'll update some dependencies in master Could you please cherry-pick these changes? :)))

Cherry pick, why? I can just merge master to the 6-2 branch

But 6.2.0 is not ready to being released yet. This Notification API fix doesn't fix https://issues.apache.org/jira/browse/OPENMEETINGS-2679. It just gets rid of some JS errors.

And yeah it would be good to verify https://issues.apache.org/jira/browse/OPENMEETINGS-2679 on the altea demo server. Once you get past the dashboard and login screen. But I tested OPENMEETINGS-2679 (including this Notification API fix) the issue still exists. And it seems more to do with signalling and how streams are created.

solomax commented 3 years ago

demo-next was just updated 2679 definitely not connected with this fix And might take significant time to fix

(and unfortunately I can't help with the fix :((( )

sebawagner commented 3 years ago

demo-next was just updated

=> I can confirm the demo server allows to load the dashboard now on iOS/Safari

There is still this error though in the iOS/Safari console:

Refused to load @.***;500;700&display=swap

I am not sure of the impact of that error. It doesn't happen on my demo servers. Is this related to html forms required for the Social login? :)

2679 definitely not connected with this fix

=> No, unfortunately not. OPENMEETINGS-2679 is not resolved. It's the same exact behaviour now on demo-next as described in the Jira. And same behaviour when testing on my other servers.

(and unfortunately I can't help with the fix :((( )

=> I think I can provide some insights. And you might be able to assist in trying to narrow down the problem. The issue seem to be that when creating a Listener and another Kurento::ObjectCreated -> New Endpoint WebRtcEndpoint But there is no FLOWING event, in a "successful" streaming/conference this event here will be triggered when creating a listener: [34mINFO [0;39m 10-06 04:41:58.105 [36mo.a.o.c.r.KStream:197 [entExec-e2-t114] [0;39m - Media Flow OUT STATE :: FLOWING, mediaType VIDEO, source [RemoteObject: type=WebRtcEndpoint remoteRef=024bd39c-cd99-4230-ba3d-62f30fdad9a4_kurento.MediaPipeline/3f554d6d-2432-41b5-912e-12f7b596db47_kurento.WebRtcEndpoint], sid 1ff7396c-3736-41a4-b349-f5839465e902, uid 86dec83a-08d5-4cd6-a25e-11c832e933a1 => This event is missing when the publishing stream is from an iOS/Safari or iOS/Chrome device.

I will write up some more details in the Jira ticket shortly.

Thanks Sebastian

Sebastian Wagner Director Arrakeen Solutions, OM-Hosting.com http://arrakeen-solutions.co.nz/ https://om-hosting.com - Cloud & Server Hosting for HTML5 Video-Conferencing OpenMeetings https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url

On Fri, 8 Oct 2021 at 05:19, Maxim Solodovnik @.***> wrote:

demo-next was just updated 2679 definitely not connected with this fix And might take significant time to fix

(and unfortunately I can't help with the fix :((( )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apache/openmeetings/pull/159#issuecomment-937946480, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHJ2QEUXCDWI7SCO6AQPLDUFXCANANCNFSM5FMROXZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.