search

apache / openmeetings

Mirror of Apache Openmeetings
Other
639 stars 260 forks source link

OPENMEETINGS-2727 Update and resync files from POEditor. #178

Closed sebawagner closed 2 years ago

sebawagner commented 2 years ago

Updated strings by re-import from POEditor. This puts it into alphabetical order. Also somehow the Indonesian translation wasn't checked in. Although on POEditor it says its some 34% translated

It also fixes a merge problem I introduced - it duplicated the strings cause the git merge did not detect the conflict. Now it should be correct again.

solomax commented 2 years ago

This commit https://github.com/apache/openmeetings/commit/c22ab0ee3ba2a532d0eee801351a65688c968488 has indonesian ... Could you please provide more info?

Thanks in advance :)

sebawagner commented 2 years ago

I Just done the export in POEditor and the Indonesian file was not included previously

When you say "Java being used" => What do you mean by that?

language codes of not imported files? => Sry? I have imported all files

solomax commented 2 years ago

"Java being used"

you are running java command line application :) Which JRE are you using? java 11? java 17?

Is Application_in.properties.xml the only file wasn't updated?

sebawagner commented 2 years ago

Java17 when using POEditor.

Ah I see, it should be called _in not _id

solomax commented 2 years ago

Well some country codes are being patched Could you please try it with JRE11

would it work?

sebawagner commented 2 years ago

I fixed it manually. The other file not updating was Hebrew (_iw)

I will try with Java11 when updating or adding another language string next time.

solomax commented 2 years ago

I'll try to check with java17 later :) will try to fix what can be fixed :)

sebawagner commented 2 years ago

I will merge this PR once the build passes. It looks fine now

solomax commented 2 years ago

OK After some debugging I find out the fact Java17 changes it's behavior :(((( We should remember it and change language file name after migrating to Java17

@sebawagner please use Java11 for import for now :(

sebawagner commented 2 years ago

Cool no worries. We can see, maybe create a Jenkins job for this tool?

Makes it easier for other devs to export the files.

Cheers Seb

On Wed, 27 Apr 2022 at 10:50 PM, Maxim Solodovnik @.***> wrote:

OK After some debugging I find out the fact Java17 changes it's behavior :(((( We should remember it and change language file name after migrating to Java17

@sebawagner https://github.com/sebawagner please use Java11 for import for now :(

— Reply to this email directly, view it on GitHub https://github.com/apache/openmeetings/pull/178#issuecomment-1110857093, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHJ2QHYQJTPVST4L3JJWY3VHELY3ANCNFSM5ULAPO3A . You are receiving this because you were mentioned.Message ID: @.***>

-- Sebastian Wagner Director Arrakeen Solutions, OM-Hosting.com http://arrakeen-solutions.co.nz/ https://om-hosting.com - Cloud & Server Hosting for HTML5 Video-Conferencing OpenMeetings https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url

solomax commented 2 years ago

maybe create a Jenkins job for this tool?

I'm usually visually check the diff Long time ago there were some issues with placeholders, and some links Not sure if this would be safe to automate :(