OPENMEETINGS-2225 fix for when in Mobile view the drop down menu is h…

[sebawagner]

OPENMEETINGS-2225 When in Mobiel view, inside the room, the navigation bar gets hidden behind the UI for the conference room.

Removing the css attribute had the effect that it moves down again.

I could not find any regression issue or bad side-effect of deleting this attribute elsewhere. But obviously I might be wrong after this long time!

see result:

[solomax]

Hello @sebawagner, I'm afraid this way chat and WB positioning in room will be broken :( this variable play it's role in 4 CSS source files have you checked those?

[sebawagner]

I see now thanks.

Do we really want to use CSS custom properties ? What is the minimum browser version we assume/require people to use?

Cheers seb

[solomax]

Variable are supported since IE11 and allow to simplify JS code a lot

For WebRTC version minimum browser versions It is MS Edge 44 (will work under Edge 14, but will be unusable) Chrome 74+, not sure about FF, but should support ~1-2 year old versions

i'll try to check this also

[sebawagner]

Well I guess you could add something like

.main.room.navExpanded {
    --room-menu-height: 188px;
}

And then add a class navExpanded to the main div. Maybe.

But I can't find any event handler that I would be able to attach an event for when the menu opens.

Is there any event handler ?

[solomax]

I did fix like this to dashboard menu The problem here: The menu size is unpredictable I'll check and will report back

[sebawagner]

yes well the other option is obviously to overlay the menu over the rest of the UI. Instead of in the background.

[sebawagner]

I've committed a new change, using z-Index to overlay the menu. It kidn of works without breaking other components.

This at least works, cause if the menu expands further it doesn't matter cause its simply on top of the elements.

but it still looks a bit strange cause the chat bar is on top of the menu still:

[sebawagner]

okay now with z-index:2010 its on top of the chat panel which is z-index: 2000

[solomax]

there is another option

as i see it the problem here is not menu but absolute top position of sidebar and white-board this can be easily fixed

[sebawagner]

the other issue is that the room-menu-height should be actually 38px not 34. Thats why it looks bit strange. But it looks bit strange like this in the dashboard then.

[solomax]

Actually the size should --room-menu-height: calc(22px + 1rem); :))) I'll create another PR with regular z-index and will ask you to review :)

[sebawagner]

The last commit I did would fix dashboard and room both to overlay.

[sebawagner]

And looks acceptable. But not sure if there is some other alternative.

[sebawagner]

yeah if fixing to not "absolute top position of sidebar and white-board" => that would be another option

But I'm not sure if that would look good if you have a very small screen and it moves everything down. Shouldn't this menu be in fact be overlay ?

On Sun, 5 Apr 2020 at 16:07, Maxim Solodovnik notifications@github.com wrote:

Actually the size should --room-menu-height: calc(22px + 1rem); :))) I'll create another PR with regular z-index and will ask you to review :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apache/openmeetings/pull/51#issuecomment-609289211, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHJ2QDOGTCTS22SEIYWR5LRK77XFANCNFSM4L7YGHEQ .

-- Sebastian Wagner https://twitter.com/#!/dead_lock seba.wagner@gmail.com

[solomax]

Alternative fix has been commited