apache / openwhisk-apigateway

Apache OpenWhisk API Gateway service for exposing actions as REST interfaces.
https://openwhisk.apache.org/
Apache License 2.0
64 stars 45 forks source link

A list of source files missing Apache license headers #273

Closed daisy-ycguo closed 6 years ago

daisy-ycguo commented 6 years ago

Following Apache license header guideline, all human-readable Apache-developed files that are included within a distribution must include the header text with few exceptions. You can find few exceptions here: which files do not require a license header.

I used Apache Rat to check this repository after excluding a few files, and I got this report. We need to add Apache licensing header to below files.

Unapproved licenses:

  openwhisk-apigateway/tools/build/scanCode.cfg
  openwhisk-apigateway/tools/travis/setup.sh
  openwhisk-apigateway/tools/travis/build.sh
  openwhisk-apigateway/tools/travis/deploy.sh
  openwhisk-apigateway/Dockerfile
  openwhisk-apigateway/Makefile
  openwhisk-apigateway/DEPENDENCIES.md
  openwhisk-apigateway/tests/run-tests.sh
  openwhisk-apigateway/tests/install-deps.sh
  openwhisk-apigateway/build_profiling.sh
  openwhisk-apigateway/doc/v1/policies.md
  openwhisk-apigateway/doc/v1/management_interface_v1.md
  openwhisk-apigateway/doc/v1/security.md
  openwhisk-apigateway/doc/profiling.md
  openwhisk-apigateway/doc/v2/management_interface_v2.md

The excluded files are:

**/*.json
**/**.gradle
**/gradlew
**/gradle/**
**/.**
**/templates/**
**/*.j2.*
**/.github/**
**/auth.whisk.system
**/auth.guest
**/i18n_resources.go
mhamann commented 6 years ago

@daisy-ycguo is there an automated tool to add those license headers?

daisy-ycguo commented 6 years ago

@mhamann Apache Rat could handle most part of those files , yet still need a human verification.

mrutkows commented 6 years ago

@daisy-ycguo is your exclusion list specific to this repo.? or is it a general list for all repos? If that is the case, we should track the general exclusion in a tracking Issue under the "release" repo. and perhaps submit a specific issue to scancode (i.e, utilities repo) which we link in the tracking issue. We should discuss the general exclusion list in detail.

mrutkows commented 6 years ago

Also, I am removing the local copy of scancode.cfg in this PR https://github.com/apache/incubator-openwhisk-apigateway/pull/289

mrutkows commented 6 years ago

In PR https://github.com/apache/incubator-openwhisk-apigateway/pull/293/files, Dragos removed Adobe from the following files

PR Add license header to 3 files #291, Daisy fixed these files:

PR Support ASF Header in .md and .sh files for scancode #292, Matt updated the following files:

PR Ensure donated IBM code uses Apache 2 headers. #296, Matt updated the following files:

PR Change hash header to latest version in .conf files. #298, updated (220 files, including notably:

PR #299 - Remove IBM copyright from LICENSE.txt , addressed these files:

mrutkows commented 6 years ago

Closing this issue and will open more granular issues for any remaining files that need to have ASF headers added.