apache / openwhisk-apigateway

Apache OpenWhisk API Gateway service for exposing actions as REST interfaces.
https://openwhisk.apache.org/
Apache License 2.0
64 stars 45 forks source link

fix(rclone): use official install mechanism #381

Closed mhamann closed 3 years ago

mhamann commented 3 years ago

Connected to https://github.com/apache/openwhisk-devtools/issues/322

I can confirm that this fixes the rclone binary, but I haven't tested it against the Docker Compose build that openwhisk-devtools is using, so I can't confirm whether that then works as intended.

I also ensured that the Docker build will fail if rclone can't be installed, which should protect us from this occurring in the future.

Here, rclone actually runs

$ docker run apigateway rclone mkdir minio:api-gateway
2020/08/06 21:36:28 Failed to create file system for "minio:api-gateway": didn't find section in config file
rabbah commented 3 years ago

Thanks Matt for the quick patch.