apache / openwhisk-catalog

Curated catalog of Apache OpenWhisk packages to interface with event producers and consumers
https://openwhisk.apache.org/
Apache License 2.0
33 stars 49 forks source link

Remove deprecated watson package #163

Closed csantanapr closed 7 years ago

csantanapr commented 7 years ago

The watson package has being replace by the three new packages

Action Items:

Refer to #154 on why the new packages were created to replace the old one.

houshengbo commented 7 years ago

I suggest not to put the package check and removal inside installWatson.sh. The install script should be focus on the installation, regardless of what is already installed or now. Watson is the first package deprecated in openwhisk-catalog, but it is definitely not the last one. We can have another script called uninstallDeprecation.sh to remove the deprecated actions and packages. The script should be able to run separately. @csantanapr What do you think?

csantanapr commented 7 years ago

Sounds better Vincent

csantanapr commented 7 years ago

Vincent let's use this new script to delete the "util" package if present. Now it should be the new "utils"

houshengbo commented 7 years ago

@csantanapr OK

csantanapr commented 7 years ago

Any other deprecated actions that need to be deleted? i.e "samples/echo" now new "utils/echo"

houshengbo commented 7 years ago

"util/cat" "util/date" "util/head" "util/sort" "util/split" "samples/echo" These are all I know. And pipe is about to remove as well, plus the 3 actions under Watson. I can put all of them in the uninstallDeprecation.sh.

rabbah commented 7 years ago

@houshengbo didn't you add a similar script before to openwhisk? i like the idea.

houshengbo commented 7 years ago

@csantanapr @rabbah That one only adds an annotation to the deprecated actions, does not delete them.

houshengbo commented 7 years ago

this issue is closed, since the pr is merged.