search

apache / openwhisk-catalog

Curated catalog of Apache OpenWhisk packages to interface with event producers and consumers
https://openwhisk.apache.org/
Apache License 2.0
33 stars 49 forks source link

Combinators package #182

Closed rabbah closed 7 years ago

rabbah commented 7 years ago 
Combinators actions:

1. eca: event-condition-action
1. forwarder: forwards incoming parameters around an action
3. retry: retry action invoke up to specified limit
4. try-cath: wrap action with a try and run catch handler on error

Installer script.
Tests.

Also did some general cleaning in this pr.

jasonpet commented 7 years ago

@rabbah - unused import errors failed travis

rabbah commented 7 years ago

Maybe we should add the slack bot pr notifier?

mrutkows commented 7 years ago

@starpit @rabbah be sure to engage the community on the "dev" list on this new package and its features, invite review/comment. thanks! oh... and of course our public Slack "dev" channel.

jasonpet commented 7 years ago

I assume @starpit is reviewing the combinators commit. The other 3 commits look good to me.

starpit commented 7 years ago

LGTM

jasonpet commented 7 years ago

merged

csantanapr commented 7 years ago

@rabbah Any hard reason Why this PR didn't include README.md updates for the new package?

I thought we try to have code+test+docs in a single PR when possible.

rabbah commented 7 years ago

Agree @csantanapr - But which is the source of truth? This https://github.com/openwhisk/openwhisk/blob/master/docs/packages.md or https://github.com/openwhisk/openwhisk-catalog/blob/master/README.md. We should not be duplicating content (This is related to https://github.com/openwhisk/openwhisk/issues/1848).

csantanapr commented 7 years ago

Agree @csantanapr - But which is the source of truth?

The corresponding repo will be the truth openwhisk-catalog/README.md

The openwhisk/docs/catalog.md it's an "alternative truth" that will be deleted soon with https://github.com/openwhisk/openwhisk/issues/1848.