search

apache / openwhisk-catalog

Curated catalog of Apache OpenWhisk packages to interface with event producers and consumers
https://openwhisk.apache.org/
Apache License 2.0
33 stars 49 forks source link

WIP: Improve optional parameter support #251

Closed jthomas closed 5 years ago

jthomas commented 6 years ago

I've hit a bug where the script doesn't allow optional parameters, even though the script supports this.

If the CATALOG_AUTH_KEY parameter is missing, the script will extract the value from:

-CATALOG_AUTH_KEY=${1:-"$OPENWHISK_HOME/ansible/files/auth.whisk.system"}

However, if I miss this parameter on the command-line, it assumes there are only two parameters, not three and fails. If I pass an empty string to force a null parameter, this doesn't pass through to the source "$SCRIPTDIR/validateParameter.sh" $1 $2 $3 correctly.

I made an attempt to fix this by using environment variables for all parameters as they are all optional.

rabbah commented 5 years ago

Will we need this if we use wskdeploy https://github.com/apache/incubator-openwhisk-catalog/pull/268?

dgrove-oss commented 5 years ago

we removed installCatalog.sh; closing this PR as out-of-date.