Adding whisk deploy manifests

apache / openwhisk-catalog

Curated catalog of Apache OpenWhisk packages to interface with event producers and consumers

https://openwhisk.apache.org/

Apache License 2.0

33 stars 49 forks source link

Adding whisk deploy manifests #268

Closed pritidesai closed 5 years ago

pritidesai commented 6 years ago

Closes #267

rabbah commented 5 years ago

Can this PR now use wsk directly instead of wskdeploy? Where do the host and key get picked up from? The actions should pin the "kind" for the runtime.

pritidesai commented 5 years ago

Can this PR now use wsk directly instead of wskdeploy?

Sure, sounds good, I can update this PR to use wsk directly instead of wskdeploy.

Where do the host and key get picked up from?

from the host and key file in core openwhisk repo: $WHISKDIR/ansible/files/auth.whisk.system

The actions should pin the "kind" for the runtime.

?? should we explicitly specify the kind while creating actions?

rabbah commented 5 years ago

We have to pin some of the nodejs actions to node 6 because they require some npm libraries not available in later runtimes. I don't know which without going through all of them.

pritidesai commented 5 years ago

Here is a list of NPM modules used throughout the entire catalog:

ws (websocket/sendWebSocketMessageAction) (ONLY IN NODE 6)
watson-developer-cloud (watson-textToSpeech/textToSpeech, watson-speechToText/speechToText) (ONLY IN NODE 6)
request (github/webhook, slack/post, weather/forecast) (SUPPORTED IN ALL)
url (github/webhook) (SUPPORTED IN ALL)
fs (watson-speechToText/speechToText) (SUPPORTED IN ALL)
stream (watson-speechToText/speechToText) (SUPPORTED IN ALL)

I have added explicit runtimes to actions which are supported in Nodejs 6 only. Let me know if there is any discrepancy or anything I need to change in manifest.

pritidesai commented 5 years ago

@rabbah this PR is ready for review, let me know your comments/feedback, thanks!

rabbah commented 5 years ago

Running the new installer, I'm encountering errors - still trying to determine why. However one thing I noticed is this error message:

Error: Deployment did not complete sucessfully. Run `wskdeploy undeploy` to remove partially deployed assets.

This should be wsk ... not wskdeploy .... @pritidesai do you agree? If so, can you help me open an issue where it is best appropriate to fix?

rabbah commented 5 years ago

There might be another bug related to wskdeploy: until I deleted my .wskprops file, I could not install the catalog using the new mechanism. The installation was going into the wrong namespace and of course the key doesn't match and isn't authorized for the other space.

Sample error:

Error: Deployment did not complete sucessfully. Run `wskdeploy undeploy` to remove partially deployed assets.
servicedeployer.go [1660]: [ERROR_WHISK_CLIENT_ERROR]: Error code: 147: The supplied authentication is not authorized to access 'guest/slack'. (code 38a382c3ce8e9d879d637671c0c97402): HTTP Response Status: 403 Forbidden HTTP Response Body: {"code":"38a382c3ce8e9d879d637671c0c97402","error":"The supplied authentication is not authorized to access 'guest/slack'."}

rabbah commented 5 years ago

I opened the following issue: https://github.com/apache/incubator-openwhisk-cli/issues/414 https://github.com/apache/incubator-openwhisk-cli/issues/413 https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1031