Closed houshengbo closed 7 years ago
Or one simple solution is we don't encrypt the file, we put them unencrypted, I notice the slack test case username and password are not encrypted.
@rabbah @houshengbo has anyone helped David in Carlos' absence?
I notice the slack test case username and password are not encrypted.
where is that?
Can you reuse the vcap path that is used for the other packages (FYI @jasonpet).
@rabbah , the slack test case not involved password, just username, apology for my description not accurate. Reuse the vcap path you mean ..., could you be a little more specific? thank you.
Look at Watson, weather and push notification packages for examples.
@lzbj - What is this issue for? Is this for converting the existing Watson tests to Scala and moving them to open? The existing Watson test used vcap and should continue to use vcap even after moving to open. Please contact me for any questions you have.
@lzbj - looking at your branch it looks like you are doing vcap right for watson translation. You still need to add the other watson tests as well. As for slack, you just need to add a vcap entry into your credentials.json.enc for slack that includes the username if you want to encrypt the username. Since you mentioned a password is not involved for slack then I am not even sure you need to use vcap for slack.
@lzbj Please check the comments I have given to the PR regarding the travis ci failure.
@houshengbo @mrutkows @rabbah @jasonpet ,thank you all, I'll look for your comments and find a solution.
@houshengbo @lzbj Can we document how to add credentials in markdown for future integrations?
@markusthoemmes I would like to mark this one as low priority, since we now need to focus on all the test cases without keys from openwhisk. This can be left in future after the catalog repo is flip on by openwhisk.
To be honest, I am not so clear of the process of adding new credentials. We still need more discussion about the way to encrypt them in travis ci. Each time we add the new credentials, an admin of the openwhisk-catalog repo has to consolidate the latest credentials, encrypt it and upload it to the repo. IMO, this is a blocker to all the other developers.
Can you clue me in - I'm confused how we will start installing the catalog from this repo if we don't know that all of the tests pass for the actions in this repo (including test cases for the watson package).
This is for all the js under watson folder.