search

apache / openwhisk-catalog

Curated catalog of Apache OpenWhisk packages to interface with event producers and consumers
https://openwhisk.apache.org/
Apache License 2.0
33 stars 49 forks source link

General directions: 1. create new test cases for creation nodejs and nodejs6? 2. adding new test if missing? #88

Closed houshengbo closed 7 years ago

houshengbo commented 8 years ago

These issues we are facing now is:

  1. Many test cases in openwhisk/tests/src/packages/UtilsTests.scala . It seems we have got all the test cases regarding the "kind: nodejs and nodejs6". Some action like greeting in samples did not have the test cases for "kind:nodejs and nodejs 6". Shall we also modify the greeting test cases by adding the tests for "kind:nodejs and nodejs 6"?
  2. Another thing is that there are test cases missing in openwhisk for many sample actions like countdown, wordcount, printparam, etc. Shall we add them during the openwhisk-catalog transition this time? Or we can leave them still empty and add them later?

@rabbah @markusthoemmes I need your folks' comments on this.

@daisy-ycguo @daisy-ycguo

rabbah commented 8 years ago

We discussed this somewhere else- maybe in one of the prs. We don't need tests for node 4 and node 6 for the packages unless the code requires a node 4 vs 6 feature. If not, use node 6 throughout.

csantanapr commented 7 years ago

everything is using nodejs6 now

will re-evaluate when we add nodejs8