apache / openwhisk-cli

Apache OpenWhisk Command Line Interface (CLI)
https://openwhisk.apache.org/
Apache License 2.0
103 stars 98 forks source link

convert secretValue int64 to string type #475

Closed steven0711dong closed 4 years ago

steven0711dong commented 4 years ago

Manual test included all the possible value combination of --web-secure and --annotation flags. The following scenarios of combination were tested:

  1. --web-secure true -a require-whisk-auth: integer
  2. --web-secure true -a require-whisk-auth: string
  3. --web-secure false -a require-whisk-auth: integer
  4. --web-secure false -a require-whisk-auth: string
  5. --web-secure true
  6. --web-secure false
  7. -a require-whisk-auth integer
  8. -a require-whisk-auth string
steven0711dong commented 4 years ago

Some of the logic associated with flag --web-secure relies on the type of the require-whisk-auth value. Converting number to string changes a lot of things. I'm still in the middle of testing out everything.