search

apache / openwhisk-client-go

Go client library for the Apache OpenWhisk platform
https://openwhisk.apache.org/
Apache License 2.0
35 stars 44 forks source link

Add CA certificate processing #109

Closed jonpspri closed 5 years ago

jonpspri commented 5 years ago

Create a '--cacert' flag that allows wsk to honor self-signing CAs if the certificate is provided. While not eliminating the need for wsk -i this does provide a more secure alternative for environments where the signing authority is stable, not needed in the system setup, and not easily changed (e.g. Kubernetes cluster development/integration installs).

There will be a corresponding PR for the CLI proper. This change should be committed first.

I have an Apache CLA on file.

rabbah commented 5 years ago

Thanks @jonpspri sorry no one reviewed this earlier. I'll merge this if you can update the branch for the conflicts.

rabbah commented 5 years ago

I think I resolved the conflicts - do you want to take a look?

jonpspri commented 5 years ago

Would be nice to have some doc demonstrating how to use the cacert flag.

@dubee - I suppose I can add a paragraph to the README.md; there doesn't seem to be a dedicated documentation folder for this library. The bulk of the documentation is in the usage for the CLI. Again, I can look to see what could be improved there. (Now I'm wondering if OpenWhisk annotates the location of its CA in its .wskprops file for local runs...)