Load X509 cert on client creation

apache / openwhisk-client-go

Go client library for the Apache OpenWhisk platform

https://openwhisk.apache.org/

Apache License 2.0

36 stars 44 forks source link

Closed tokenclt closed 5 years ago

tokenclt commented 5 years ago

This PR proposes a fix for issue #111. Changes are:

Execute LoadX509Cert when creating Client, instead of making requests.
Prefer to use the provided Transport (from httpClient argument of NewClient), only create a new Transport when user sets Cert, Key and Insecure.
Fix some go vet suggestions.

BTW, I've submitted the Apache CLA and I'm waiting for the confirmation email.

csantanapr commented 5 years ago

Thank you @AprliRainkun 👍

@dubee or @mdeuser could you review as your earliest convenience 🙏

csantanapr commented 5 years ago

Thanks @rabbah and @mdeuser for the quickly jumping on this PR review 👍