search

apache / openwhisk-client-go

Go client library for the Apache OpenWhisk platform
https://openwhisk.apache.org/
Apache License 2.0
36 stars 44 forks source link

Additional HTTP Headers #67

Closed dubee closed 6 years ago

dubee commented 6 years ago

Allows for additional HTTP headers to be configured for the HTTP client.

dubee commented 6 years ago

@mdeuser, please you review.

dubee commented 6 years ago

@mdeuser

mdeuser commented 6 years ago

@dubeejw is the intent to provide per-request specific headers? if so, it might be more flexible to include the additional headers via the requestUrl() functions as opposed to the global client configuration

dubee commented 6 years ago

@mdeuser, AdditionalHeaders is meant for consumers of client-go that do not have access to requestUrl().

mdeuser commented 6 years ago

i think i understand. this is for setting a header that will appear in any/all subsequent request to the backend; not for setting header(s) on a per-request basis. LGTM.. but perhaps a comment on that AdditionalHeaders would help clarify.