search

apache / openwhisk-client-go

Go client library for the Apache OpenWhisk platform
https://openwhisk.apache.org/
Apache License 2.0
35 stars 44 forks source link

swagger schema hardocded and references ibm properties #87

Open rabbah opened 6 years ago

rabbah commented 6 years ago

This schema should not include IBM specific properties:

See https://github.com/apache/incubator-openwhisk-client-go/blob/1759868a61729708a8ab1a6de1b409d6e2aea00a/whisk/api.go#L153-L154

I think the entire struct should be removed anyway - it overly restricts the schema unnecessarily.

csantanapr commented 6 years ago

Why? this limits are applicable and valid to open source gateway

csantanapr commented 6 years ago

They are not ibm specific

rabbah commented 6 years ago

The fields are hard coded and called “x-ibm-...“ as in:

x-ibm-configuration x-ibm-rate-limit

csantanapr commented 6 years ago

Yeah for backwards compatibility the it can x-ibm or “x- something else” don’t remember right now what’s the other option for the same

csantanapr commented 6 years ago

Both work in the api gateway

rabbah commented 6 years ago

There are no references to XConfig or XRateLimit in the project - how about we remove them... actually I'd remove the entire class, I don't think these types help much anyway and just over constrain the schema ---- or as shown several times, they get out of sync.

rabbah commented 6 years ago

See ongoing discussion here: https://github.com/apache/incubator-openwhisk-client-go/pull/88