search

apache / openwhisk-client-js

JavaScript client library for the Apache OpenWhisk platform
https://openwhisk.apache.org/
Apache License 2.0
83 stars 53 forks source link

Allow environment level set of default user-agent #183

Closed purplecabbage closed 5 years ago

purplecabbage commented 5 years ago

Currently it is very difficult to set the user agent globally. We have a library which is using this library, and changing the user-agent to something we can track requires modifying the options to every client call.

codecov-io commented 5 years ago

Codecov Report

Merging #183 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files          14       14           
  Lines         409      409           
=======================================
  Hits          406      406           
  Misses          3        3
Impacted Files Coverage Δ
lib/client.js 98.85% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update feb6a88...478c413. Read the comment docs.

jthomas commented 5 years ago

This makes sense to me (once the code review changes has been implemented).

purplecabbage commented 5 years ago

Thanks @jthomas !

jthomas commented 5 years ago

no problem - will be pushing out a new release of the library soon.