Read from file not implemented

[singhsegv]

I am trying to use this with a basic example where my composition.py file and the function program files are located in the same directory.

This is what my hello.py looks like:

def main(args):
    print("Hello")
    print(args)
    return {"key": "hello"}

And this is how my composition.py looks like:

import composer

def main():
  return composer.action("HELLO", {
        "filename": hello.py",
        "limits": {
            "memory": "128",
        }
    })

I am getting the "read from file not implemented" error.

[singhsegv]

I see this in line 451 composer.py

 elif 'filename' in options and isinstance(options['filename'], str): # read action code from file
        raise ComposerError('read from file not implemented')
        # exc = fs.readFileSync(options.filename, { encoding: 'utf8' })

Any specific reason for not allowing the filename option? Any workarounds?

[rabbah]

@singhsegv did you try using the JavaScript composer instead? This python version hasn't been maintained. You're welcome to send a PR though if you like.

[singhsegv]

Would love to raise a PR of this. Is there a contribution guideline or development setup guideline that you can point me to for this project?

And yeah, Javascript composer worked out for me.

[rabbah]

https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md mainly you need an ICLA if it's a substantial change