search

apache / openwhisk-composer

Apache OpenWhisk Composer provides a high-level programming model in JavaScript for composing serverless functions
https://openwhisk.apache.org/
Apache License 2.0
68 stars 21 forks source link

conductor should obey INSECURE_SSL in wskprops #13

Closed starpit closed 5 years ago

starpit commented 5 years ago

conductor parses out wskprops, but ignores the INSECURE_SSL setting that might be asserted in that file: https://github.com/apache/incubator-openwhisk-composer/blob/master/conductor.js#L52-L55

i notice that in the tests, the insecure ssl part is asserted via an env var: https://github.com/apache/incubator-openwhisk-composer/blob/master/test/conductor.js#L26

i suggest that we should behave as does the go cli, in its INSECURE_SSL behavior.

tardieu commented 5 years ago

do you have a pointer to the matching go cli code?

tardieu commented 5 years ago

We also need to fix the use of insecure_certs at run time (as discussed in #16).

dgrove-oss commented 5 years ago

@tardieu -- resolved by #21?

tardieu commented 5 years ago

The deploy command now obeys the __OW_IGNORE_CERTS environment variable in addition to the -i flag as defined by the OpenWhisk client for javascript.

The conductor action code obeys the $composer.openwhisk.insecure_ssl invocation parameter.

By default neither deploying, nor running compositions ignores ssl certificate validation failures.